Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platforms: add Pine64 Star64 #283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

platforms: add Pine64 Star64 #283

wants to merge 2 commits into from

Conversation

Ivan-Velickovic
Copy link
Contributor

For once all the Star64 PRs are merged.

@Ivan-Velickovic Ivan-Velickovic requested a review from lsf37 as a code owner August 22, 2023 00:18
@Ivan-Velickovic
platforms: add Pine64 Star64
17951c4 
Signed-off-by: Ivan-Velickovic <[email protected]>
Ivan-Velickovic
Ivan-Velickovic commented Aug 22, 2023
View reviewed changes
seL4-platforms/platforms.yml
smp: [64]
platform: star64
req: [star64]
march: rv64imac
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what march does exactly here, march: rv64gcb would be more accurate for the Star64. The only use of march I can see is here

ci-actions/seL4-platforms/platforms.py

Lines 183 to 192 in 607634d

def getISA(self, mode: int) -> str:
"""Return the ISA for this platform"""
if self.arch == "x86":
return {32: "IA32", 64: "x86_64"}[mode]
if self.arch == "riscv":
return {32: "RC32IMAC", 64: "RV64IMAC"}[mode]
return self.march.capitalize()
, where it seems to be ignoring march anyways.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong, but I think the only remaining use of march is for grouping in CI matrices. We could try to eliminate it and see what happens..

lsf37
lsf37 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy for you to merge once the other PRs are done.

(Ok to ignore the devscript link failure for this PR)

@axel-h axel-h mentioned this pull request Jan 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsf37 lsf37 lsf37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivan-Velickovic @lsf37